Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for IRC channel names in use by other teams. #1407

Closed

Conversation

valberg
Copy link
Collaborator

@valberg valberg commented Jul 30, 2023

No description provided.

@valberg valberg requested a review from tykling July 30, 2023 20:53
@valberg valberg linked an issue Jul 30, 2023 that may be closed by this pull request
@github-actions
Copy link

Test Results

103 tests  ±0   102 ✔️ ±0   0s ⏱️ ±0s
  24 suites ±0       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit e0a7d44. ± Comparison against base commit 808dd3c.

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #1407 (e0a7d44) into master (808dd3c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
+ Coverage   60.42%   60.44%   +0.02%     
==========================================
  Files         617      617              
  Lines       13482    13476       -6     
==========================================
  Hits         8146     8146              
+ Misses       5336     5330       -6     
Files Changed Coverage Δ
src/teams/models.py 75.96% <ø> (+3.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tykling
Copy link
Member

tykling commented Sep 24, 2023

the ACL for irc channels is determined by the team, if multiple teams can have the same IRC channel then we need to decide how to handle the ACL

@tykling
Copy link
Member

tykling commented May 27, 2024

closing for now

@tykling tykling closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team IRC channel constraints are overly pedantic
2 participants