Fix - Navigation doesn't highlight current page

[borntofrappe]

[borntofrappe]

If you inspect the source the aria-current attribute wraps the string page between a superfluous set of quotes.

<a href="/" aria-current=""page"">Home</a>

[borntofrappe]

It seems the issue stems from how the helper function injects the ARIA attribute, and the data-active attribute for that matters. You need to escape

<a
  href="{{item.url}}"
  {{helpers.getLinkActiveState(item.url, page.url)}}>
    {{item.text}}
</a>

You need to add the safe filter to avoid escaping the input.

{{helpers.getLinkActiveState(item.url, page.url)}}
+{{helpers.getLinkActiveState(item.url, page.url) | safe}}

[borntofrappe]

05246ee closes the issue.

Modifying the helper function would also work if you were to remove the quotes.

 response += ' aria-current="page"';
-response += ' aria-current=page';

I would discourage this approach however, as it creates confusion with how you expect HTML attributes to work. Relying on the safe filter clearly states that the output is to be treated as markup.