Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must_use on SimpleLogger methods #60

Closed
kartva opened this issue Jun 30, 2022 · 2 comments
Closed

must_use on SimpleLogger methods #60

kartva opened this issue Jun 30, 2022 · 2 comments

Comments

@kartva
Copy link
Contributor

kartva commented Jun 30, 2022 •
edited
Loading

Placing #[must_use] on most methods on SimpleLogger would help remind users to use init to actually initialize the logger.

I'd be happy to work on this as well.
@borntyping
Copy link
Owner

I'd be very happy to accept an MR adding this :)

@kartva
Copy link
Contributor Author

kartva commented Jun 30, 2022 •
edited
Loading

It seems that #25 has dealt with this already. Huh, I could've sworn that I didn't see any warnings when using the crate, but testing it now seems to work. False alarm.

@kartva kartva closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@borntyping @kartva