Skip to content

Commit

Permalink
Ignore vendored tests/JSONTestSuite
Browse files Browse the repository at this point in the history 
Fixes incorrect repository language detection.
https://github.com/github/linguist#overrides
  • Loading branch information
@lukateras
lukateras committed Dec 22, 2016
1 parent 88ef704 commit dabeb93
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .gitattributes
View file
@@ -0,0 +1 @@
tests/JSONTestSuite/* linguist-vendored

4 comments on commit dabeb93

@decentral1se
Copy link

@decentral1se decentral1se commented on dabeb93 Feb 12, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegortimoshenko could the failure in commercialhaskell/stackage#2291 be related to this change?

Just doing some sniffing around, not really sure.

@decentral1se
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run tests locally, I see:

λ ~/hobby/aeson/tests/JSONTestSuite/ master* python3 run_tests.py
-- /home/lwm/hobby/aeson/tests/JSONTestSuite/parsers/test_jsonChecker/bin/jsonChecker /home/lwm/hobby/aeson/tests/JSONTestSuite/test_parsing/n_number_0e.json
Traceback (most recent call last):
  File "run_tests.py", line 670, in <module>
    run_tests(restrict_to_path)
  File "run_tests.py", line 308, in run_tests
    timeout=5
  File "/home/lwm/.pyenv/versions/3.5.2/lib/python3.5/subprocess.py", line 557, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/home/lwm/.pyenv/versions/3.5.2/lib/python3.5/subprocess.py", line 947, in __init__
    restore_signals, start_new_session)
  File "/home/lwm/.pyenv/versions/3.5.2/lib/python3.5/subprocess.py", line 1551, in _execute_child
    raise child_exception_type(errno_num, err_msg)
OSError: [Errno 8] Exec format error

And also:

λ ~/hobby/aeson/ master* stack test
FromJSONKey:
    -: [OK]
    -: [OK]
    -: [OK]
    -: [Failed]
...
         Properties    Test Cases    Total        
 Passed  220           484           704          
 Failed  0             1             1            
 Total   220           485           705          

Completed 39 action(s).
Test suite failure for package aeson-1.1.0.0
    tests:  exited with: ExitFailure 1
Logs printed to console

@lukateras
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwm Impossible. This attribute is used only in github/linguist.

@decentral1se
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks 👍

Please sign in to comment.