Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prysm client to require 40k Boa stake as defined in Bosagora whitepaper. #7

Closed
MichaelKim20 opened this issue May 6, 2022 · 9 comments
Assignees

Comments

@MichaelKim20
Copy link
Member

MichaelKim20 commented May 6, 2022

The minimum staking amount required to become a validator is 40,000 BOA in the white paper of BOSAGORA.
We need to modify the code according to this.
The Beacon chain has a number of implementations.
First of all, we use prysm.
https://github.com/zeroone-boa/prysm

@linked0
Copy link

linked0 commented May 10, 2022

We can use this constant in the config.file and the value of 32e9 gwei(= 32 eth) is set to the constant in the source code.

MaxEffectiveBalance       uint64 `yaml:"MAX_EFFECTIVE_BALANCE" spec:"true"`       // MaxEffectiveBalance is the maximal amount of Gwei that is effective for staking.

@hewison-chris hewison-chris changed the title Changing the amount of staking Update Prysm client to require 40k Boa stake as defined in Bosagora whitepaper. May 10, 2022
@hewison-chris hewison-chris transferred this issue from another repository May 12, 2022
@linked0
Copy link

linked0 commented May 18, 2022

I have changed the MaxEffectiveBalance to 40000e9 in the two config files, minimal_config.go and mainnet_config.go for this issue.
We should pass the unit tests for the change. So, I'm working on the errors on unit tests.

@linked0
Copy link

linked0 commented May 18, 2022

After the above change, we should change this line in the deposit-contract/scripts/staking.ts file.

@MichaelKim20
Copy link
Member Author

After the above change, we should change this line in the deposit-contract/scripts/staking.ts file.

We have to check this out, too. https://github.com/zeroone-boa/deposit-contract/blob/1ddcecf590e8be9aeeda1897cf339125e12b1f79/contracts/deposit_contract.sol#L113-L115
We need to check why Ethereum's minimum staking amount is 1 Ether.
Why should there be a minimum amount separately?

@MichaelKim20
Copy link
Member Author

MichaelKim20 commented May 22, 2022

I have changed the MaxEffectiveBalance to 40000e9 in the two config files, minimal_config.go and mainnet_config.go for this issue. We should pass the unit tests for the change. So, I'm working on the errors on unit tests.

What is MinDepositAmount , Ejection Balance, Effective Balance Increment?
What should we do with their value?

@MichaelKim20
Copy link
Member Author

MichaelKim20 commented May 22, 2022

There seems to be something to change in the code of the repository below.
I'd appreciate it if you could check.
https://github.com/zeroone-boa/staking-deposit-cli

@linked0
Copy link

linked0 commented May 22, 2022

After the above change, we should change this line in the deposit-contract/scripts/staking.ts file.

We have to check this out, too. https://github.com/zeroone-boa/deposit-contract/blob/1ddcecf590e8be9aeeda1897cf339125e12b1f79/contracts/deposit_contract.sol#L113-L115

OK, I will. And besides that, I will change the ether and gwei to boa and cent in all the related source code as a separate PR.

We need to check why Ethereum's minimum staking amount is 1 Ether. Why should there be a minimum amount separately?

Right, I also thought the constant should be researched. At the moment, I think that the deposit could be done several times with the minimum amount. I will leave the result of the research.

@linked0
Copy link

linked0 commented May 23, 2022

As suggested here by @hewison-chris, We could set the MAX_EFFECTIVE_BALANCE to like 400K(the more proper value could be set later) and also MIN_DEPOSIT_BALANCE to 40K, which makes us give as much rewards to validators based on the amount of their deposit. I will consider how to apply it after confirming there is no problem with setting MAX_EFFECTIVE_BALANCE to 40K at first.

@MichaelKim20
Copy link
Member Author

We learned the following from Jay's research.
We found out that we can solve this value by modifying the parameter in Prysm.
And this value, which is scattered in various repositories, will proceed with the revision of the project.

Then I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants