Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to the local-testnet to create transactions and assert correct behavior #46

Closed
3 tasks done
hewison-chris opened this issue Aug 19, 2022 · 4 comments
Closed
3 tasks done
Assignees

Comments

@hewison-chris
Copy link
Contributor

hewison-chris commented Aug 19, 2022

To ensure that transactions are handled correctly and fees are paid to Commons Budget and Validators as expected we need some tests.
Some basic tests to start with

  • Transactions are added to the block and BOA account balances are updated correctly when money is transfered
  • 30% Transaction fees are paid to the Commons Budget
  • 70% Transaction fees are paid to the chosen Block proposing Validator

If problems are found then we may have more development work still to do on the explorer and client code.

@mkykadir
Copy link

https://github.com/zeroone-boa/local-testnet/pull/82 resolves the first two tests, the third test requires some new implementations that I will make, which are;

  1. Web3 Python seems to don't have Clique.API implemented, so an individual HTTP request need to be created to fetch the block signer
  2. Previous amounts for all miners (i.e. signers) must be fetched before sending TX, only the signer amount can be fetched for checking 70% fee reward

I tested the 70% reward by hand, it works with no problem

@mkykadir
Copy link

https://github.com/zeroone-boa/local-testnet/pull/83 tests for the 70% tx fee to miner

@hewison-chris
Copy link
Contributor Author

hewison-chris commented Sep 13, 2022

Same tests can be run after

  • Bellatrix fork
  • Capella fork (new test for withdrawal)
  • last commons budget reward block

@mkykadir
Copy link

https://github.com/zeroone-boa/local-testnet/pull/84 tests for the block rewards to commons budget

@mkykadir mkykadir removed their assignment Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants