Try to stop everything before setting config list #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
kfabian
approved these changes
Mar 21, 2023
kfabian
reviewed
Mar 21, 2023
| } | ||
| catch (const std::runtime_error & error) | ||
| { | ||
| std::cerr << error.what() << std::endl; |
There was a problem hiding this comment.
Since we handle the case of an error, would it make more sense to just log the error with debug log level?
There was a problem hiding this comment.
I just thought to output a runtime error as an error.
syyuen
approved these changes
Mar 21, 2023
|
Hi, would it be possible to merge this bugfix into the noetic-v1.7 branch as well? |
@tessa-j yes, but the branch noetic-v1.7 is only compatible to ROKIT Locator v1.7, which is only available for cooperation partners for evaluation purpose. |
syyuen
pushed a commit
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.