Update doc humble #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheung Ying Yuen-Wille <SheungYing.Yuen@bosch.com>
Signed-off-by: Sheung Ying Yuen-Wille <SheungYing.Yuen@bosch.com>
kfabian
requested changes
Nov 3, 2023
README.md
Outdated
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_galactic.yml) | ||
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_humble.yml) | ||
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_rolling.yml) | ||
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_galactic.yml) |
There was a problem hiding this comment.
Do we still want the galactic action?
There was a problem hiding this comment.
It looks like humble and galactic is mixed up here.
There was a problem hiding this comment.
Yes, it should only be Humble.
There was a problem hiding this comment.
removed the line for galactic
slaible
requested changes
Nov 6, 2023
README.md
Outdated
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_galactic.yml) | ||
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_humble.yml) | ||
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_rolling.yml) | ||
| [](https://github.com/boschglobal/locator_ros_bridge/actions/workflows/build_galactic.yml) |
There was a problem hiding this comment.
Yes, it should only be Humble.
README.md
Outdated
| @@ -21,7 +18,7 @@ It also allows to control the ROKIT Locator via ROS service calls. | |||
|
|
|||
| There are versions for the following ROS 1 and ROS 2 distributions: | |||
| * ROS 1: Noetic (this branch, will likely also work on Melodic) | |||
| * ROS 2: Foxy (branch [foxy](../../tree/foxy)), Rolling (branch [main](../../tree/main), will likely also work on Galactic) | |||
| * ROS 2: Humble (branch [humble](../../tree/humble), will likely also work on Galactic) | |||
There was a problem hiding this comment.
I guess, it will likely not work on Galactic any more (because of changes in Nav2). ;-) So we should remove the comment regarding Galactic.
Signed-off-by: Sheung Ying Yuen-Wille <SheungYing.Yuen@bosch.com>
slaible
approved these changes
Nov 6, 2023
kfabian
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.