Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error in 2.1.9 branch main-v1.6 #50

Closed
Phymin opened this issue Dec 14, 2023 · 6 comments
Closed

Build error in 2.1.9 branch main-v1.6 #50

Phymin opened this issue Dec 14, 2023 · 6 comments

Comments

@Phymin
Copy link

Phymin commented Dec 14, 2023

Please see the following screenshot for detail:
859868d2844ea62d3fb9cb0c5318233

@kfabian
Copy link
Collaborator

kfabian commented Dec 14, 2023

There is no branch main-v1.6(you probably meant main-v1.4). Only the bridge versions for the latest locator versions are actively maintained. The main-v1.4 branch builds against ROS2 galactic, from the compile errors it looks like it is build against humble or newer. If you want to continue with main-v1.4 and ROS2 humble, you could simply try to cherry-pick this commit 0f797e1.

@Phymin
Copy link
Author

Phymin commented Dec 15, 2023

Hi,

I got this branch from your colleague HongKui Tang, you can checkout this branch with git checkout 2.1.9 -b main-v1.6, because he found that in v1.8, there is big delay of the localization with picoscan lidar, we also like to know when will this issue be fixed in v1.8? thanks

@thkfighter
Copy link
Contributor

OS: Ubuntu 22.04
ROS Humble
Locator 1.6.4
LiDAR: picoScan150

According to the last chapter of locator_ros_bridge/bosch_locator_bridge/README.md of latest commit (2a3363a) of branch humble,

If you have version 1.6 of ROKIT Locator, checkout the corresponding tag:
git checkout 2.1.9 -b main-v1.6

With commit 8bf9a58, tag 2.1.9, there are some errors when building this package, all related to sub-package bosch_locator_bridge_utils, as shown in the picture posted by @Phymin on first floor. These errors have been fixed in a later commit, 8696169.

My temporary solution:

git clone --branch=humble https://github.com/boschglobal/locator_ros_bridge.git
cd locator_ros_bridge
cp -r ./bosch_locator_bridge_utils <src_folder_of_your_ros2_ws>
git checkout 2.1.9 -b main-v1.6
cp -r ./bosch_locator_bridge <src_folder_of_your_ros2_ws>

A better solution is need.

@kfabian
Copy link
Collaborator

kfabian commented Dec 19, 2023

As mentioned in my first answer, the error when building version 2.1.9 with humble occurs because this version is compatible with galactic. As mentioned in the changelog of the locator_bridge_utils the upgrade to humble was only made in version 2.1.10. Nevertheless the changes for humble are only minor and can be ported back by cherry picking commits 0f797e1 and 545c902, e.g.

git cherry-pick 0f797e1 545c902

Also note that the locator_bridge_utils are only needed for Nav2 integration, if you don not need them you can just skip building them, e.g.

colcon build --packages-skip bosch_locator_bridge_utils

@kfabian
Copy link
Collaborator

kfabian commented Feb 5, 2024

@Phymin @thkfighter can this be closed?

@thkfighter
Copy link
Contributor

@Phymin @thkfighter can this be closed?

Yes. Please close it. @kfabian

@kfabian kfabian closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants