-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename faas to function #210
Conversation
I assume this is a typo 😄 |
Yeah :) I've updated the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a few small changes. The big thing is that I should land #202 and you should rebase, then do pkger
. The Node.js and Quarkus changes you have made here won't get picked up without it. :)
@lance thanks for the review, fixed |
@zroubalik lgtm - unless @rhuss has any concerns let's do it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me (but see my comments).
Alson not sure about that pkged.go file (can't add a comment there). What is this ?
Beside this (and reading the changes), I wonder whether we should add at least func
as an alias as this is much shorter and would be a perfect drop-in replacement for faas
when it comes to the length of the command. Also I would be in favor of a func.yaml
over function.yaml
.
@@ -1,8 +1,2837 @@ | |||
{ | |||
"name": "event-handler", | |||
"version": "0.1.0", | |||
"lockfileVersion": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file supposed to be part of this renaming PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, don't know how does this end up here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these files get modified after running make test. The deps needed to be updated.
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@rhuss Thanks for the review. I have fixed the things from your comments, and renamed Is it ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but there are still some references to function.yaml
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Thanks ! /lgtm |
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
This PR renames:
faas
->function
FAAS_
->FUNCTION_
faas.yaml
->func.yaml
quay.io/boson/faas
->quay.io/boson/function
Fixes: #201