Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unselecting all User Roles causes all to be selected #1

Closed
grahamarmfield opened this issue Nov 23, 2018 · 1 comment
Closed

Unselecting all User Roles causes all to be selected #1

grahamarmfield opened this issue Nov 23, 2018 · 1 comment

Comments

@grahamarmfield
Copy link

When the plugin is first activated, no user roles appear to be selected in the settings page.

I can then select one or more and press Save Settings.

Then if I deselect all of them and press Save Settings, all of them are checked.

@boswall
Copy link
Owner

boswall commented Nov 28, 2018

Hmm, yes I wasn't sure what best to do when all the user roles are deselected; that would not show the CSS in any circumstance. What do feel would be the best action here? Allow the user to make this error? Show a warning?

I had thought the system would auto select all user roles, but had not tested it properly. Let me investigate.

boswall added a commit that referenced this issue Nov 28, 2018
boswall added a commit that referenced this issue May 17, 2019
@boswall boswall closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants