Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users cannot distinguish one issue from another #3

Closed
boswall opened this issue Apr 9, 2019 · 1 comment
Closed

Users cannot distinguish one issue from another #3

boswall opened this issue Apr 9, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@boswall
Copy link
Owner

boswall commented Apr 9, 2019

There are currently only 2 colours used (red and gold) to show the issues. I think this was to denote the severity of the issues.

This does not give any details of what the issue is (only that an issues exists) and means that the usability of the plugin is very limited. You have to inspect an element to know what the issue is.

My plan was to add a title attribute to the highlighted elements so that users could hover over them to see a description. However, elements with title attributes are something that is highlighted in the CSS and not very accessible.

Another option would be to add an ::after pseudo element with some text. This would only show one issue at a time and may break some themes (if the theme uses the pseudo element).

Another option would be to use different colours for each type of issue and add a legend for users to refer to.

Any other thoughts?

@boswall boswall added the enhancement New feature or request label Apr 9, 2019
@boswall
Copy link
Owner Author

boswall commented Jul 24, 2019

v1.1 uses JavaScript to find the issue elements, so I was able to also inject a new element just after the issue element. I can then add the issue label(s) to that new element.

This should mean that there are no potential compatibility issues with themes using ::after

@boswall boswall closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant