True conditional migrations #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this by setting toVersion to null
A constant migration is defined as any migration that doesn't migrate to a new version, i.e. ConditionalMigration or custom subclasses
This effectively replaces buildMigrationMap with a function that more closely resembles runConstantMigrations
Also create ResultTest.kt and ResultBenchmark.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking: This change modifies the ConditionalMigration structure, as well as makes changes to the base Migration interface.
I've set up a more proper structure for running conditional migrations, which also doesn't require specifying a
toVersionanymore, which means conditional migrations are "truly conditional".Internally, migrations that don't specify a
toVersionare referred to as "Constant migrations", since they won't modify the Migrator version. Migrations that specifytoVersionare classified as "Versioned migrations", whether they implementVersionedMigrationor not.Resolves #10