Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Groups multiple recipients #683

Closed
rickkuilman opened this issue Jan 9, 2018 · 2 comments
Closed

Command Groups multiple recipients #683

rickkuilman opened this issue Jan 9, 2018 · 2 comments

Comments

@rickkuilman
Copy link
Contributor

I have made an enhancement in the 'recipients' command groups so that multiple recipients can be access the group.

$botman->group(['recipient' => '700001'], function($bot) {
  ...
});
$botman->group(['recipient' => ['700001', '700002', '700003']], function($bot) {
  ...
});

For now I have hacked it into place, but if this enhancement is appreciated by more people I can turn it into well structured code with tests. So, is this a nice little addition or should this be implemented differently (via middleware or something)?

@mpociot
Copy link
Member

mpociot commented Jan 9, 2018

I like this 👍
If you want, send me a PR :)

@rickkuilman
Copy link
Contributor Author

Aight, cool. Expect something later this week (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants