Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db_subnet_group to restore_dbinstance_from_point_in_time #1640

Merged

Conversation

reversefold
Copy link
Contributor

So you can use point-in-time restores with VPC.

@toastdriven
Copy link
Contributor

Overall, this looks like a good change. However, to be merged, it'll need tests. If you can write a test covering the addition, that would be great. Otherwise, it'll need to wait for a core dev to have time to add one.

The correct place would be within https://github.com/boto/boto/blob/develop/tests/unit/rds/test_connection.py. Just needs to cover the new flag.

@reversefold
Copy link
Contributor Author

I don't see any tests for restore_dbinstance_from_point_in_time at all so I can't simply add this parameter to the existing tests. It seems a bit disingenuous to require unit tests for simple changes which add missing parameters when there are no unit tests covering the code yet as it is.

@reversefold
Copy link
Contributor Author

I've added minimal tests to cover the default parameters and the subnet group name using the AWS example response.

@ghost ghost assigned danielgtaylor Aug 19, 2013
@danielgtaylor
Copy link
Member

This LGTM now that tests have been added 👍

danielgtaylor added a commit that referenced this pull request Aug 21, 2013
Add db_subnet_group to restore_dbinstance_from_point_in_time. Fixes #1640.
@danielgtaylor danielgtaylor merged commit 71911e9 into boto:develop Aug 21, 2013
@reversefold reversefold deleted the point_in_time_db_subnet_group branch August 21, 2013 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants