This repository has been archived by the owner on May 10, 2024. It is now read-only.
Handle both JSONDecodeError and ValueError due to differences in json vs. simplejson #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplejson has JSONDecodeError, but json doesn't.
…irm that both are caught and the expected service exception gets raised.
| @@ -291,7 +299,7 @@ def __call__(self, query): | |||
| r = requests.get(url, params=params) | |||
| try: | |||
| data = json.loads(r.content) | |||
| except json.JSONDecodeError,e: | |||
| except (JSONDecodeError, ValueError), e: | |||
There was a problem hiding this comment.
What was the reason for not just catching ValueError?
…ut that JSONDecodeError inherits from ValueError. Tests continue to pass.
|
LGTM. 🚢-ing it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges in #1633 from @kurin, but makes the following changes:
JSONDecodeErrorandValueError