iam: add support for Account Password Policy APIs #2574
Conversation
|
cc @gvarisco |
|
Thanks for the pull request! This looks great, but before it can be merged you will need to add tests to cover the new functions. Please add tests and comment back on this issue and then I'll merge it in. |
lucab
force-pushed
the
lucab/to-upstream/iam-password-policy
branch
from
1ddcbb9
to
7bd265a
Compare
|
Ah sorry, I didn't realize there was a compulsory test suite. Added unit and integration tests, and properly tagged another existing IAM test in the meanwhile. Rebased on current develop, all green on travis. |
|
@danielgtaylor can you have another look at it and merge if ok? |
|
@kyleknap @danielgtaylor another month passed, any chance to have this merged? It looks like people started reimplementing the same code (see PR #2658) and I'm losing motivation to continuously rebase my branch for conflicts, just to endlessly wait for another conflict to happen... |
|
@lucab sorry for the slow response. The code looks great, thanks for updating it 👍 Unfortunately it looks like it can't be merged cleanly, so if you can rebase one last time and ping us we'll pull it in for the next release, thanks! |
This commits adds support to iam module for all currently available APIs related to Account Password Policy, introducing three new public methods: * get_account_password_policy() * delete_account_password_policy() * update_account_password_policy() IAM Password Policy and API reference: http://docs.aws.amazon.com/IAM/latest/UserGuide/Using_ManagingPasswordPolicies.html Signed-off-by: Luca Bruno <luca.bruno@rocket-internet.de>
This commit adds one unit and one integration test for the IAM Account Password Policy methods. Signed-off-by: Luca Bruno <luca.bruno@rocket-internet.de>
Signed-off-by: Luca Bruno <luca.bruno@rocket-internet.de>
lucab
force-pushed
the
lucab/to-upstream/iam-password-policy
branch
from
7bd265a
to
a788932
Compare
|
Rebased against current develop branch by tail-appending my changes. Tests are ok locally, travis is green. |
|
Thanks! Merging pull request. |
…licy iam: add support for Account Password Policy APIs
|
👍 |
|
Awesome, thanks for merging. You may want to mark PR #2658 as duplicate fixed, too. I see we are rapidly approaching 200 queued PRs. Is there anything that we (as in, external contributors) can do to drain the backlog? |
This commits adds support to IAM module for all currently available APIs
related to Account Password Policy, introducing three new public methods:
IAM Password Policy and API reference:
http://docs.aws.amazon.com/IAM/latest/UserGuide/Using_ManagingPasswordPolicies.html
Signed-off-by: Luca Bruno luca.bruno@rocket-internet.de