Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify_reserved_instances ignores target_configuration.instance_type #2860

Closed
jbylund opened this issue Jan 6, 2015 · 1 comment
Closed

Comments

@jbylund
Copy link

jbylund commented Jan 6, 2015

The ec2connection.modify_reserved_instances ignores an instance_type attribute in the target configuration.
To recreate purchase 2 x m3.medium reservations, then attempt to merge to 1 x m3.large.
I'm using
python: Python 2.7.8 (from ubuntu repos)
boto: 0dadce8

The diff that I have locally is:

diff --git a/boto/ec2/connection.py b/boto/ec2/connection.py
index 1956d7d..07b7bc6 100644
--- a/boto/ec2/connection.py
+++ b/boto/ec2/connection.py
@@ -3785,6 +3785,8 @@ class EC2Connection(AWSQueryConnection):
                 params[prefix + 'Platform'] = tc.platform
             if tc.instance_count is not None:
                 params[prefix + 'InstanceCount'] = tc.instance_count
+            if tc.instance_type is not None:
+                params[prefix + 'InstanceType'] = tc.instance_type

     def modify_reserved_instances(self, client_token, reserved_instance_ids,
                                   target_configurations):
@jbylund
Copy link
Author

jbylund commented Aug 22, 2015

Merged as 958b7c8.

@jbylund jbylund closed this as completed Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant