Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additional available Boto3 specific events #3352

Closed
Frederik-Baetens opened this issue Jul 25, 2022 · 6 comments
Closed

Document additional available Boto3 specific events #3352

Frederik-Baetens opened this issue Jul 25, 2022 · 6 comments
Labels
documentation This is a problem with documentation. feature-request This issue requests a feature. p3 This is a minor priority issue

Comments

@Frederik-Baetens
Copy link

Describe the issue

The following three events to register handlers to are already documented here:

  • creating-client-class
  • creating-resource-class
  • provide-client-params

However, it seems that the following undocumented events are also available for registering handlers:

  • before-call
  • before-sign
  • ...?

Is there a reason why these additional events aren't documented?

Links

https://boto3.amazonaws.com/v1/documentation/api/latest/guide/events.html#boto3-specific-events

@Frederik-Baetens Frederik-Baetens added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jul 25, 2022
@tim-finnigan
Copy link
Contributor

Thanks @Frederik-Baetens for reaching out. I'll bring this up with the team and confirm if we should update that documentation. I'll post another comment here when I have an update.

@tim-finnigan tim-finnigan added feature-request This issue requests a feature. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 26, 2022
@aBurmeseDev aBurmeseDev added the p3 This is a minor priority issue label Nov 3, 2022
@tim-finnigan
Copy link
Contributor

Checking in again @Frederik-Baetens - thanks for your patience. Are there specific events you want to see documented that currently are not? Is there any particular use case you were wondering about?

@tim-finnigan tim-finnigan added response-requested Waiting on additional information or feedback. and removed needs-review labels Apr 12, 2023
@Frederik-Baetens
Copy link
Author

Hi, yes, I would mainly like to see the before-call event being documented. I could not find it listed on this page: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/events.html

@github-actions github-actions bot removed the response-requested Waiting on additional information or feedback. label Apr 17, 2023
@Frederik-Baetens
Copy link
Author

Would be fixed by #3686

@tim-finnigan
Copy link
Contributor

Closing as #3686 was just merged. The documentation should be updated in the next release. Thanks @jonathan343!

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. feature-request This issue requests a feature. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

3 participants