Add back missing fast fail states to create/update cfn waiters #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackCreateComplete can transition to a ROLLBACK_COMPLETE when waiting for stack creation to complete. The only action upon reaching this state is to delete the stack.
For the update stack complete waiter, a failed update can result in an UPDATE_ROLLEBACK_COMPLETE. The unfortunate part here you cannot use this waiter until you call UpdateStack, which is the only cfn waiter that has this restriction. This means a previous UpateStack failed, calling the StackUpdateComplete waiter before calling UpdateStack will immediately trigger the fast fail case.
jamesls
added
the
pr/needs-review
Current coverage is 97.57% (diff: 100%)@@ develop #1056 diff @@
==========================================
Files 44 44
Lines 6917 6917
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6749 6749
Misses 168 168
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back ROLLBACK_COMPLETE as a terminal failure state
StackCreateComplete can transition to a ROLLBACK_COMPLETE
when waiting for stack creation to complete. The only action
upon reaching this state is to delete the stack.
Add back UPDATE_ROLLBACK_COMPLETE as fast fail case in waiter
For the update stack complete waiter, a failed update can result in
an UPDATE_ROLLEBACK_COMPLETE. The unfortunate part here you
cannot use this waiter until you call UpdateStack, which is the
only cfn waiter that has this restriction. This means a previous
UpateStack failed, calling the StackUpdateComplete waiter
before calling UpdateStack will immediately trigger the fast
fail case.
cc @kyleknap @JordonPhillips