Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore ignore "HTTP/<version> 100" #1943

Closed
zhaoyujing opened this issue Jan 16, 2020 · 1 comment
Closed

botocore ignore "HTTP/<version> 100" #1943

zhaoyujing opened this issue Jan 16, 2020 · 1 comment
Assignees
Labels
duplicate This issue is a duplicate. enhancement This issue requests an improvement to a current feature.

Comments

@zhaoyujing
Copy link

def _is_100_continue_status(self, maybe_status_line):
    parts = maybe_status_line.split(None, 2)
    # Check for HTTP/<version> 100 Continue\r\n
    return (
        len(parts) >= 3 and parts[0].startswith(b'HTTP/') and
        parts[1] == b'100')

If boto3 recv "HTTP/ 100" but not "HTTP/ 100 continue", botocore will ignore this message because "len(part3)" with be 2. Maybe botocore should ignore the reason-phrase content.

@swetashre swetashre self-assigned this Jan 16, 2020
@swetashre
Copy link
Contributor

@zhaoyujing - Thank you for your post. We are tracking this issue under the issue #1931. There is also a PR submitted with the fix. Let's track this issue under the linked github issue.

I am closing this one as duplicate.

@swetashre swetashre added duplicate This issue is a duplicate. enhancement This issue requests an improvement to a current feature. labels Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate. enhancement This issue requests an improvement to a current feature.
Projects
None yet
Development

No branches or pull requests

2 participants