Add support for new retry modes #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the concept of "retry modes" which allows us to introduce different retry behavior. The default mode, `legacy`, is the existing retry behavior. This means that new retry modes (in v1) require an opt-in. The new `standard` mode moves away from the `_retry.json` and contains a set of errors that are retried that is now consistent with other AWS SDKs implementing standard mode. This mode also adds support for retry quotas which control how many unsuccessful retries a client can make. As part of this change, I've added a new total_max_attempts config option. This addresses the fact that there's already a max attempts client config var in botocore v1, and that it doesn't mean the same thing as the `AWS_MAX_ATTEMPTS` env var. To summarize: * The client config's `max_attemtps` remains unchanged. * A new `total_max_attempts` var is added that maps to the `AWS_MAX_ATTEMPTS` and `max_attempts` env var and config file values. * We internally convert client config `max_attempts` to `total_max_attempts` and ensure internally (in args.py and client.py) we only use this new value.
This adds a new experimental retry mode, `adaptive`, that adds support for client side rate limiting based on receiving throttling responses. `adaptive` mode includes all the behavior on `standard` mode.
jamesls
requested review from
stealthycoin,
joguSD,
kyleknap and
nateprewitt
This was referenced Feb 13, 2020
Codecov Report
@@ Coverage Diff @@
## develop #1972 +/- ##
===========================================
+ Coverage 92.73% 92.98% +0.24%
===========================================
Files 53 60 +7
Lines 10293 10784 +491
===========================================
+ Hits 9545 10027 +482
- Misses 748 757 +9
Continue to review full report at Codecov.
|
|
We should also add a changelog entry for the new modes before merging. |
jamesls
added a commit
that referenced
this pull request
Feb 14, 2020
PR #1972 * v1-new-retries: Add changelog entry for new retry feature Add support for adaptive mode retries Add support for retries v2 standard mode Add support for parsing retryable metadata in model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing retryable metadata in model
Add support for retries v2 standard mode
This adds the concept of "retry modes" which allows us to
introduce different retry behavior.
The default mode,
legacy, is the existing retry behavior.This means that new retry modes (in v1) require an opt-in.
The new
standardmode moves away from the_retry.jsonandcontains a set of errors that are retried that is now consistent
with other AWS SDKs implementing standard mode. This mode also
adds support for retry quotas which control how many unsuccessful
retries a client can make.
As part of this change, I've added a new total_max_attempts config
option.
This addresses the fact that there's already a max
attempts client config var in botocore v1, and that it
doesn't mean the same thing as the
AWS_MAX_ATTEMPTSenv var. To summarize:
max_attemptsremains unchanged.total_max_attemptsvar is added that maps to theAWS_MAX_ATTEMPTSandmax_attemptsenv var and config filevalues.
max_attemptstototal_max_attemptsand ensure internally (in args.py andclient.py) we only use this new value.
Add support for adaptive mode retries
This adds a new experimental retry mode,
adaptive, that addssupport for client side rate limiting based on receiving
throttling responses.
adaptivemode includes all the behavioron
standardmode.