Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urllib3 version upgrade to >2.0 #3120

Closed
2 tasks
jleaniz opened this issue Feb 14, 2024 · 3 comments
Closed
2 tasks

Urllib3 version upgrade to >2.0 #3120

jleaniz opened this issue Feb 14, 2024 · 3 comments
Labels
duplicate This issue is a duplicate.

Comments

@jleaniz
Copy link

jleaniz commented Feb 14, 2024

Describe the feature

Any reason why urllib3 versions are restricted to certain v1 versions?

Use Case

Strict urllib3 version requirements to v1 don't allow projects that depend on botocore to use urllib3 >= 2.0

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.34.41

Environment details (OS name and version, etc.)

Ubuntu Jammy

@jleaniz jleaniz added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Feb 14, 2024
@nateprewitt
Copy link
Contributor

Hi @jleaniz ,

This appears to be a duplicate of #2926. Boto3 and Botocore do support urllib3 2.0 on Python 3.10+. Versions of Python prior to that point will break with urllib3 2.0 in many environments such as AWS Lambda so we can't move that pin.

The latest version of urllib3 2.2 has a handful of additional breaking changes which is why we currently cap at 2.0.7.

I'll resolve this in favor of the primary tracking ticket linked above.

Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@nateprewitt nateprewitt added duplicate This issue is a duplicate. and removed feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Feb 14, 2024
@jleaniz
Copy link
Author

jleaniz commented Feb 14, 2024

Thanks, looks like 2.0.7 works for us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate.
Projects
None yet
Development

No branches or pull requests

2 participants