Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/Export Service API CHANGE... Missing GenerateShippingLabel API Call #431

Closed
kingb opened this issue Jan 7, 2015 · 3 comments
Closed

Comments

@kingb
Copy link

kingb commented Jan 7, 2015

A call to the Import/Export Service API, specifically, an import call to CreateJob, use to return a field called 'AwsShippingAddress' which no longer exists. Instead it requests a call to GenerateShippingLabel, which is not currently possible in botocore, AWS CLI, or boto3. The API version number has not changed, so why did the API change? Or am I missing something?

Now CreateJob states as part of the response['WarningMessage']:

Please use GetShippingLabel API endpoint to print your shipping label.

Note response was created with:

    client = session.create_client('importexport', 'us-east-1')
    response = client.create_job(ValidateOnly=True, Manifest=final_manifest, JobType='Import')

A quick search of the documentation shows the new GetShippingLabel action: http://docs.aws.amazon.com/AWSImportExport/latest/DG/WebGenerateShippingLabel.html

Notice that the botocore client interface is missing the generate_shipping_label function:

    In [61]: client = session.create_client('importexport', 'us-east-1')

    In [62]: client.
    client.can_paginate   client.get_paginator  client.update_job
    client.cancel_job     client.get_status     client.waiter_names
    client.clone_client   client.get_waiter     
    client.create_job     client.list_jobs  

Note the low-level interface does not support the operation:

    In [64]: import_export_api = session.get_service('importexport')

    In [65]: endpoint = import_export_api.get_endpoint('us-east-1')

    In [66]: import_export_api.operations
    Out[66]:
    [Operation:CancelJob,
     Operation:CreateJob,
     Operation:GetStatus,
     Operation:ListJobs,
     Operation:UpdateJob]
@kingb
Copy link
Author

kingb commented Feb 3, 2015

@danielgtaylor, @jamesls, could we get an update on the status of this? This API change broke our product for a client and we are stuck waiting for a fix. Why did the API change without boto being updated and without a version number of the API being updated?

@jamesls
Copy link
Member

jamesls commented Feb 3, 2015

@kingb This is now fixed in the latest release of botocore (0.85.0) from last week. Looks like the commit that fixed this was not linked to this issue.

I apologize for the delay in getting this API updated. Generally, we are in sync with service updates as they occur. We've passed along feedback about this breaking change to the service team. I agree that breaking changes generally have an API version bump. We will work to ensure this does not happen again. Thanks for your patience with this.

@jamesls jamesls closed this as completed Feb 3, 2015
@kingb
Copy link
Author

kingb commented Feb 5, 2015

@jamesls Excellent. Thank you for the update. I appreciate you looking into the sync with service updates. Thank you for all your hard work on this. Keep up the great work guys! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants