Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlidingWindowSemaphore uses TaskSemaphore as a base class #251

Open
cfxegbert opened this issue Nov 5, 2022 · 0 comments
Open

SlidingWindowSemaphore uses TaskSemaphore as a base class #251

cfxegbert opened this issue Nov 5, 2022 · 0 comments

Comments

@cfxegbert
Copy link

SlidingWindowSemaphore inherits TaskSemaphore but overrides all of its methods. TaskSemaphore has a _semaphore member variable which is not used by SlidingWindowSemaphore. __init__ is never called on the base class so the member is not created but could cause future maintenance headaches.

A new base interface class needs to be created or just use duck typing for the semaphore classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfxegbert