Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice-skills regenerates randomId on save #909

Closed
epaminond opened this issue Jan 14, 2020 · 0 comments
Closed

Choice-skills regenerates randomId on save #909

epaminond opened this issue Jan 14, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@epaminond
Copy link

Describe the bug

When saving existing choice-skill randomId gets regenerated. This:

  • breaks some of the logic that is depending on variables that are set within skill-choice
  • generates multiple changes that makes commits look "not clean" and makes reviewing more time-consuming.

To Reproduce
Steps to reproduce the behavior:

  1. Go to studio and open a flow with existing choice-skill
  2. Open choice-skill and press "Save" without editing
  3. Check changes via git
  4. See multiple changes connected to randomId being regenerated

Expected behavior
randomId doesn't change and ideally no changes occur.

Screenshots
image

Environment (please complete the following information):

  • OS: Ubuntu 16.04
  • Browser chrome
  • Version 12.3.1
  • NodeJS 10.11
@epaminond epaminond added the bug Something isn't working label Jan 14, 2020
allardy referenced this issue in botpress/botpress Jan 20, 2020
fix(studio): keep randomId on choice edit (resolve #2813)
@michaelmass michaelmass transferred this issue from botpress/botpress Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants