feat(chat): chat service #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmasse
commented
Aug 17, 2021
Comment on lines
+29
to
30
| const { conversationId, payload } = req.body | ||
| const conversation = await this.conversations.get(conversationId) |
There was a problem hiding this comment.
TODO: remove channel from request schema. Also remove from client
samuelmasse
commented
Aug 17, 2021
| } | ||
| } | ||
|
|
||
| async send(conversationId: uuid, authorId: uuid | undefined, payload: any, from: any): Promise<Message> { |
There was a problem hiding this comment.
TODO: remove all the code from this function and make it event based (maybe?)
samuelmasse
commented
Aug 17, 2021
| @@ -10,7 +10,6 @@ export class ConvmapTable extends Table { | |||
| table.uuid('tunnelId').references('id').inTable('msg_tunnels').notNullable() | |||
| table.uuid('conversationId').references('id').inTable('msg_conversations').notNullable() | |||
| table.uuid('threadId').references('id').inTable('msg_threads').notNullable() | |||
| table.unique(['tunnelId', 'conversationId']) | |||
There was a problem hiding this comment.
TODO: migration to remove this unique constraint
samuelmasse
commented
Aug 17, 2021
| @@ -10,7 +10,6 @@ export class UsermapTable extends Table { | |||
| table.uuid('tunnelId').references('id').inTable('msg_tunnels').notNullable() | |||
| table.uuid('userId').references('id').inTable('msg_users').notNullable() | |||
| table.uuid('senderId').references('id').inTable('msg_senders').notNullable() | |||
| table.unique(['tunnelId', 'userId']) | |||
There was a problem hiding this comment.
TODO: migration here as well (do we even need usermap?)
samuelmasse
added a commit
that referenced
this pull request
Aug 19, 2021
* use latest client version * ddd * fix * add socket.io * cors * very basic communication with server * bump client version * feat(server); nologo option * doc * put back old stuff * implement events make render structure * better setup * test messages * locale * ui helpers * improvement * ui error handling * element * style and textbox * storage * client deserialize dates * deserialize health * message form * postMessage * dont post when empty * convo details * seperate debug ui * save convo * refact ui * fix * remove random lodash * setup socket.io * send better messages * disconnect * base package * skin package * yarn.lock * move things to skin package * emitter to base * fix * socket request * some progress * reorg * functionning one way * dirty but it works * chore(base): implement base package * remove unused files * move rewire * fixes * remove ts-config-paths * use yarn workspace script * remove client from root references * scroll to bottom on message * some css * refactor 1 * refact * refact * user events * cleanup webchat * rename * cleanup 2 * dark theme * lang * socket package * socket package ++ * manual connect * socket package progress * various fixes * socket service * remove socket and web channel * user sockets schemas * messages socket schema * safety improvements * fix * cache sockets * fix * feat(chat): chat service (#135) * chat service * remove dead code * fix * refact socket service * fix * faster caching * fix * refact * fix * fix * better ui * ENABLE_EXPERIMENTAL_SOCKETS * sandbox * undo changes in table * users.auth validate client exists * fix keep channel name when only one convmap * fixes * fix * typings for send * STORAGE_ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP