Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): add convo and user events #168

Merged
merged 10 commits into from
Sep 8, 2021
Merged

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Sep 2, 2021

This PR adds a conversation created and user created webhook event. I figured the way we were doing webhooks was all over the place so I created a StreamService who's role is to stream what happens on the server to listeners. These listeners can be sockets or webhooks. I also completely removed the chat service and api.

Closes DEV-1598

Related to botpress/botpress#5406

@linear
Copy link

linear bot commented Sep 2, 2021

packages/server/src/instances/service.ts Show resolved Hide resolved
packages/server/src/stream/service.ts Show resolved Hide resolved
packages/server/src/stream/service.ts Show resolved Hide resolved
packages/server/src/stream/service.ts Outdated Show resolved Hide resolved
packages/server/src/stream/service.ts Show resolved Hide resolved
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some tests but other than that, LGTM! Nice work!!!

@samuelmasse samuelmasse merged commit 2e30ddd into master Sep 8, 2021
@samuelmasse samuelmasse deleted the sm-convo-and-user-wh branch September 8, 2021 19:06
@laurentlp laurentlp mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants