Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(client): better error handling #198

Merged
merged 2 commits into from
Oct 14, 2021
Merged

chore(client): better error handling #198

merged 2 commits into from
Oct 14, 2021

Conversation

laurentlp
Copy link
Contributor

This PR improves the error handling in the HTTP client so that every function that makes a call to the API properly handles all possible errors.

samuelmasse
samuelmasse approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@samuelmasse samuelmasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice I didn't know axios could to that

@laurentlp laurentlp merged commit df62c65 into llp_better_not_found_handling Oct 14, 2021
@laurentlp laurentlp deleted the llp_client_better_error_handling branch October 14, 2021 15:58
laurentlp added a commit that referenced this pull request Oct 14, 2021
@laurentlp
chore(api): better handling of entity not found (#197)
0a547e2 
* chore(api): better handling of entity not found

* chore(client): better error handling (#198)

* chore(client): better error handling

* small refactor
laurentlp added a commit that referenced this pull request Oct 15, 2021
@laurentlp
feat(api): add a route to get user info (#195)
7441823 
* feat(api): add a route to get user info

* pr comment

* chore(api): better handling of entity not found (#197)

* chore(api): better handling of entity not found

* chore(client): better error handling (#198)

* chore(client): better error handling

* small refactor
@EFF EFF mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmasse samuelmasse samuelmasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laurentlp @samuelmasse