fix(server): fix response to other node #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-1977 Ensure that botpress sending answer to other messaging server still works
If messaging node 1 is connected to a socket, and it sends a message to a runtime, and this runtime answers on messaging node 2, this node can't send the message to the socket connected on node 1. So we need to have pub sub with redis to solve this. |
laurentlp
reviewed
Nov 12, 2021
laurentlp
approved these changes
Nov 22, 2021
This was referenced Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a situation in converse or websocket where sending a response message to a node other than the node where the converse request was made or where the websocket is connected would result in the response being lost.
Closes DEV-1977