feat(telegram): telegram v1 #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review but I need to add the handling the version management in the backend for channels. Right now you can use this new telegram implementation as a drop in for the previous one, but we'll have it as a different version |
samuelmasse
commented
Jan 26, 2022
samuelmasse
commented
Jan 26, 2022
samuelmasse
commented
Jan 26, 2022
Comment on lines
+94
to
+95
| // TODO: remove this dependency on server env vars | ||
| return !yn(process.env.SPINNED) || yn(process.env.CLUSTER_ENABLED) |
There was a problem hiding this comment.
TODO: need to do this. Should be a allowSockets configuration or something like that.
samuelmasse
commented
Jan 26, 2022
samuelmasse
commented
Jan 26, 2022
|
TODO: add a way to disable automatic webhook creation. This should be an option in all channels |
laurentlp
approved these changes
Jan 28, 2022
samuelmasse
force-pushed
the
sm-telegram-v2
branch
from
ec88a15
to
294106c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of telegram channel with telegraf v4.6.0 (upgraded from the old version that used 3.27.1)
Closes DEV-2251