Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(twilio): twilio v1 #324

Merged
merged 37 commits into from
Jan 29, 2022
Merged

feat(twilio): twilio v1 #324

merged 37 commits into from
Jan 29, 2022

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Jan 26, 2022

Upgrades twilio channel to use twilio package 3.73.1 instead of 3.67.0

There's barely any changes since it was mostly up to date. Added support for file, audio, video and location content. Files and videos are sent as a link, audio is supported by twilio and gets disaplayed as playable audio (at least in android sms app). Locations are sent by constructing an url using the google maps api.

Closes DEV-2250

@linear
Copy link

linear bot commented Jan 26, 2022

DEV-2250 Twillio

@samuelmasse
Copy link
Contributor Author

TODO: possibly add an option to disable mms (and down render every media to just an url)

@samuelmasse samuelmasse changed the title feat(twilio): twilio v2 feat(twilio): twilio v1 Jan 28, 2022
Base automatically changed from sm-channels-v2 to master January 28, 2022 23:19
@samuelmasse samuelmasse merged commit a1acd2f into master Jan 29, 2022
@samuelmasse samuelmasse deleted the sm-twilio-v2 branch January 29, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants