Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): auto start error 404 instead of 500 #335

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Feb 2, 2022

Fixes a problem where webhook requests with provider names that do not exist would return a 500 error. Since it's more a not found error I changed it so it returns 404 instead.

Closes DEV-2284

@linear
Copy link

linear bot commented Feb 2, 2022

@samuelmasse samuelmasse changed the title fix(instance): auto start error 404 instead 500 fix(instance): auto start error 404 instead of 500 Feb 2, 2022
packages/channels/src/base/channel.ts Outdated Show resolved Hide resolved
@samuelmasse samuelmasse merged commit 4671560 into master Feb 2, 2022
@samuelmasse samuelmasse deleted the sm-auto-start-not-found branch February 2, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants