feat(webchat): local storage encryption #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlp
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
LGTM! Simply enough, nice work!!!! 💪
Also, as a note, when you'll be integrating the components from ui-shared-lite, there is a window.BP_STORAGE class that we use in the webchat to access the local or session storage. I think we should deprecate this class and simply use the helpers you edited in the socket.ts file and make put them in their own file. What do you think?
| @@ -228,6 +228,8 @@ export interface Config { | |||
| chatId?: string | |||
| /** CSS class to be applied to iframe */ | |||
| className?: string | |||
| /** Key used to encrypt data in the localStorage */ | |||
There was a problem hiding this comment.
Can you add that the key is auto-generated for better security and that I user shouldn't provide one?
There was a problem hiding this comment.
I mean it's auto-generated from the outside, but the webchat itself doesn't generate that key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DEV-2363