Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(channels): channel validation #437

Merged
merged 25 commits into from
Apr 12, 2022
Merged

Conversation

samuelmasse
Copy link
Contributor

@samuelmasse samuelmasse commented Apr 5, 2022

Adds e2e channel validation when sync is called

Closes DEV-2428

@linear
Copy link

linear bot commented Apr 5, 2022

DEV-2428 Channel configuration validation

Do we do tests before accepting you channel configuration, or we let it fail when you get your first message?

What we need is /sync call to fail (that would be the first pre-flight check for chatbots)

@laurentlp laurentlp self-requested a review April 6, 2022 17:07
@samuelmasse samuelmasse marked this pull request as ready for review April 7, 2022 14:54
packages/channels/src/base/service.ts Show resolved Hide resolved
packages/channels/src/messenger/stream.ts Outdated Show resolved Hide resolved
packages/channels/src/messenger/stream.ts Show resolved Hide resolved
packages/channels/src/smooch/service.ts Show resolved Hide resolved
packages/server/src/instances/lifetime/service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@laurentlp laurentlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working! Nice job!!!!

@samuelmasse samuelmasse merged commit 23a6990 into master Apr 12, 2022
@samuelmasse samuelmasse deleted the sm-channel-validation branch April 12, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants