-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slack): allow receiving file/audio/video/image #573
Conversation
await this.service.receive( | ||
scope, | ||
{ identity: '*', sender: message.user, thread: message.channel }, | ||
{ type: this.mapMimeTypeToStandardType(file.mimetype), url: file.url_private, title: file.title } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is url_private
reachable ? or is it actually private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EFF It is private, meaning that only people with access to the organization that the Bot is part of will have access to that image, but at the same time, only people from the org will have access to the bot anyways. The only way to have a public image, in this case, would be to have a service to re-upload those images to S3 (which we don't have to any channel, including those where the generated Image URL is temporary[telegram]).
At the same time, it's totally possible to download this image in a hook using the botToken and the Slack API and upload it somewhere else.
OBS: There is no public URL available in the payload received
Did you try to build and test a docker image ? Just to make sure sqlite works. It always been a tricky dep to update. |
@EFF I tested it locally using a standalone messaging server that connects to my PG database (this sqlite update was just so I'm able to build it). My Botpress instance points to the same database. We will do more testing with the full server as soon as we have this merged, so if something happens, I will fix this repo too |
@davidvitora any updates ? |
@EFF Hey Eff, I believe that I answered your question regarding this PR. Is there anything else missing on my side? |
This PR adds support for receiving files (file/audio/video/image) with Slack (channel v1.0.0 only).
Similar to #543
Also updated sqlite3 since install is failing on Mac M1