fix(messenger): allow buttonless card #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidvitora
force-pushed
the
dv_fix_facebook_button
branch
from
fb0de84
to
dfca189
Compare
michaelmass
approved these changes
Apr 18, 2023
EFF
reviewed
Apr 27, 2023
| @@ -30,7 +30,7 @@ export interface MessengerCard { | |||
| title: string | |||
| image_url?: string | |||
| subtitle?: string | |||
| buttons: MessengerButton[] | |||
| buttons?: MessengerButton[] | |||
There was a problem hiding this comment.
non-blocking: making this prop optional will force you to always check if its defined everywhere. IMO you should leave this non optional and make it an empty array whenever you construct the object
There was a problem hiding this comment.
@EFF Empty arrays will actually break messenger :( , I believe that is why there was a push on line 48 before
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today it's impossible to have a card without a button; this PR fixes it. I believe that before, it was not allowed because you can't send an empty button list, if you do, the card is not displayed on Messenger; my PR will make sure that there is at least one button before creating the property.