chore(nlu-client): refactor client so it throws meaningful errors if it needs to #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklevasseur
added a commit
that referenced
this pull request
Nov 18, 2021
…Server and Duckling (#118) * feat(nlu-client): server now return typed error structures on failure * chore(nlu-engine): engine reads package version from index * chore(lang-client): create package lang client to query lang server with typings (#117) * chore(lang-client): create package lang client to query lang server with typings * minor refactoring + updated some dependencies * feat(lang-server): minor changes to language server's API for more coherent types * minor fixes in lang provider * fix prettier * chore(lang-server): put back some request validation in tokenize route * only one error handling mw * chore(nlu-engine): only one allowed lang source * do not catch lang-server connections error * chore: done implementing lang-client * rm problematic test that can't be fixed * chore(e2e): update test results * chore(lang-client): better logging on failure * catch logger promise * minor fix * feat: language-server errors are typed in nlu-server's API * chore: all errors that may occur durring comm with lang-server are typed as lang-server errors * feat: duckling throws errors that are typed in nlu-server's API (#123) * feat: duckling throws errors that are typed in nlu-server's API * fix duckling tests * feat: nlu-server also returns lang and duckling servers errors at predict time * chore(nlu-client): refactor client so it throws meaningful errors if it needs to (#124) * chore(nlu-client): refactor client so it throws meaningfull errors if it needs to * fix unit tests * chore(lang): increase lang server version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slight refactoring