Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): various cli improvements #144

Merged
merged 8 commits into from Nov 26, 2021
Merged

feat(cli): various cli improvements #144

merged 8 commits into from Nov 26, 2021

Conversation

franklevasseur
Copy link
Member

@franklevasseur franklevasseur commented Nov 26, 2021

This PR includes:

  1. the download command is now a subcommand of lang: ./nlu lang download --dim 100 --lang fr
  2. all default config values were moved at a single location
  3. every cli parameter can be replaced by an env variable instead. Environment variables are generated from yargs schema builder
  4. json config file now has a schema that is generated from yargs schema builder
  5. subcommands init (./nlu init && ./nlu lang init) generate empty json configuration files with a schema in app data

Here's the priority order in case of conflict:

cli arg > config file > env variable

@franklevasseur franklevasseur marked this pull request as draft November 26, 2021 17:00
@franklevasseur franklevasseur marked this pull request as ready for review November 26, 2021 18:49
@franklevasseur franklevasseur merged commit 4f53fae into cloud Nov 26, 2021
@franklevasseur franklevasseur deleted the cli_improvements branch March 23, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant