Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): fix up metrics to be 1 instead of 0 #166

Merged
merged 1 commit into from Jan 29, 2022
Merged

fix(metrics): fix up metrics to be 1 instead of 0 #166

merged 1 commit into from Jan 29, 2022

Conversation

michaelmass
Copy link
Collaborator

The metric up should always be 1 so using signalIsUp method sets it to 1.

franklevasseur
franklevasseur requested changes Jan 28, 2022
View reviewed changes
Copy link
Member

@franklevasseur franklevasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve your variable naming. Try something like:

setTheServerSignalToOneOrInOtherWordUpAsItWillFurtherHelpMonitoringTheNLUServer()

franklevasseur
franklevasseur approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@franklevasseur franklevasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(lgtm)

@franklevasseur franklevasseur merged commit 81c287a into cloud Jan 29, 2022
@franklevasseur franklevasseur deleted the mm-metrics branch January 12, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklevasseur franklevasseur franklevasseur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelmass @franklevasseur