-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flow): fix editing content elements using action modal #109
Conversation
DEV-1636 "[BUG] Updating Image Content Image UI issue" (botpress/studio #75)
Describe the bug To Reproduce
Expected behavior Environment (please complete the following information):
This causes frustration that happens when you think you updated something and you didn't. botpress/studio #75 by @ptrckbp on GitHub via LinearSync |
packages/studio-ui/src/web/components/Content/Select/Widget.tsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/src/web/components/Content/Select/Widget.tsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/src/web/views/FlowBuilder/nodeProps/TransitionSection.jsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/src/web/views/FlowBuilder/nodeProps/ActionSection.jsx
Outdated
Show resolved
Hide resolved
packages/studio-ui/src/web/views/FlowBuilder/nodeProps/TransitionSection.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR fixes an issue where when editing content elements (image, video, audio, file) it was possible to save an empty value.
Before
simplescreenrecorder-2021-09-21_17.57.28.mp4
After
simplescreenrecorder-2021-09-21_17.54.03.mp4
Closes #75 and DEV-1636