Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): fix editing content elements using action modal #109

Merged
merged 5 commits into from
Sep 28, 2021

Conversation

laurentlp
Copy link
Contributor

@laurentlp laurentlp commented Sep 20, 2021

This PR fixes an issue where when editing content elements (image, video, audio, file) it was possible to save an empty value.

Before

simplescreenrecorder-2021-09-21_17.57.28.mp4

After

simplescreenrecorder-2021-09-21_17.54.03.mp4

Closes #75 and DEV-1636

@linear
Copy link

linear bot commented Sep 20, 2021

DEV-1636 "[BUG] Updating Image Content Image UI issue" (botpress/studio #75)

Describe the bug
image
When updating url in an Image Content's Image input, you can click the Submit button without actually updating the field.

To Reproduce
Steps to reproduce the behavior:

  1. Go to flow page
  2. Create a node
  3. Add an action, Image type, with image and title.
  4. Go back to action, and change the image text. Click Submit, not OK (see the image)

Expected behavior
There should be a confirmation pop-up, or the submit button should be disabled (due to no changes being detected), or the change should go through.

Environment (please complete the following information):

  • OS: macOS
  • Browser Chrome
  • Browser Version Version 92.0.4515.131 (Official Build) (x86_64)
  • Botpress Version 12.25.0
  • NodeJS 12.13.0

This causes frustration that happens when you think you updated something and you didn't.


botpress/studio #75 by @ptrckbp on GitHub

via LinearSync

@laurentlp laurentlp marked this pull request as ready for review September 21, 2021 23:55
EFF
EFF previously approved these changes Sep 28, 2021
Copy link
Member

@EFF EFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EFF EFF merged commit c021286 into master Sep 28, 2021
@EFF EFF deleted the llp_fix_action_modal_save branch September 28, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Updating Image Content Image UI issue
3 participants