Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qna): fix language dropdown overlay issue #115

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Conversation

EFF
Copy link
Member

@EFF EFF commented Sep 23, 2021

The issue is easily reproductible. I thought it was a z-index thing but turns out z-index don't apply to position:relative elements. Removing that position relative statement had me play around with a bunch of styles. In the end, there is no visible change except the actual fix (see screencaps)

Before :
Screen Shot 2021-09-23 at 11 48 16 AM

After:
Screen Shot 2021-09-23 at 11 46 59 AM

Closes botpress/v12#1466 DEV-1693

Copy link
Member

@allardy allardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EFF EFF merged commit 056686b into master Sep 23, 2021
@laurentlp laurentlp deleted the fd_fix-qna-overlay-issue branch February 3, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Z-Index issue when trying to translate Q&A
2 participants