fix(studio): allow changing content-type when editing node content-element #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentlp
changed the title
DEV-1535 "[BUG]: Failing to change Content Element" (botpress/botpress botpress/v12#1430)
Describe the bug To Reproduce
Expected behavior Screenshots Environment (please complete the following information):
botpress/botpress botpress/v12#1430 by @Michael-N-M on GitHub via LinearSync |
|
I see pretty much only typing fix, cab you point out where the actual fix is in your changes |
laurentlp
commented
Sep 27, 2021
Comment on lines
231
to
235
| renderCurrentCategoryInfo() { | ||
| const { categories } = this.props | ||
| const { hideCategoryInfo } = this.state | ||
| if (hideCategoryInfo || !categories || categories.length < 2) { | ||
| if (!categories || categories.length < 2) { | ||
| return null | ||
| } |
There was a problem hiding this comment.
Here is the fix. I simply removed the hideCategoryInfo condition.
There was a problem hiding this comment.
Yeah I thought that. Any idea why was it there in the first place ?
EFF
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where when editing a selected content-element in a node, it would not let you change the content-type. The option was only provided when adding a content-element.
Before
simplescreenrecorder-2021-09-24_10.58.25.mp4
After
simplescreenrecorder-2021-09-24_10.56.37.mp4
Closes botpress/v12#1430
Also closes DEV-1535