Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(studio): no ghost flows when deleting a bot #160

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

allardy
Copy link
Member

@allardy allardy commented Nov 1, 2021

When you delete a bot, flows in the studio are not cleared correctly so they stayed in memory and were displayed if you re-created a bot with the same id.

This is a quick workaround to cleanup correctly

Fixes https://linear.app/botpress/issue/DEV-1670/[bug]-deleted-bots-not-being-deleted-properly-botpressbotpress-5393****

@ptrckbp ptrckbp self-requested a review November 1, 2021 21:15
Copy link
Contributor

@ptrckbp ptrckbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite simple, and does the trick!

@allardy allardy merged commit 60825f3 into x-meta Nov 1, 2021
@franklevasseur franklevasseur mentioned this pull request Nov 4, 2021
EFF added a commit that referenced this pull request Nov 19, 2021
fix(studio): prevent using skills in folde rname (#157)
fix(studio): no ghost flows when deleting a bot (#160)
fix(studio): fix error when renaming node (#159)
fix(studio): warns user about double braces (#168)
fix(studio): Warns user he will be logged out (#185) 
fix(studio): more time for logging that user is logged out (#192)
@laurentlp laurentlp deleted the ya-fix-bot-ghost-flows branch February 3, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants