Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(debugger): Voice-Content Type in Emulator #163

Merged
merged 3 commits into from
Nov 1, 2021
Merged

fix(debugger): Voice-Content Type in Emulator #163

merged 3 commits into from
Nov 1, 2021

Conversation

ierezell
Copy link
Contributor

@ierezell ierezell commented Nov 1, 2021 •
edited by EFF

Closes DEV-1835
Closes botpress/v12#1481

from the original issue screenshot a null check was missing.

image

Inspecting messages works fine.

@EFF EFF changed the title fix: Voice-Content Type in Emulator fix(debugger): Voice-Content Type in Emulator Nov 1, 2021
@ierezell ierezell requested a review from EFF November 1, 2021 16:49
@EFF EFF merged commit da4c466 into x_big-nepl Nov 1, 2021
@linear
Copy link

linear bot commented Nov 11, 2021

DEV-1835 [BUG] Google-Speech configuration Refers to the Global Config (botpress/borpress botpress/v12#1483)

Describe the bug
When clicking the global google-speech config then change to bot google-speech config, it still refers to the global one. Most probably because the two files have the same name, so the editor thinks it is the same fill

To Reproduce
1- Activate Google-Speech module
2- Go into your bot
3- Click the global google-speech configuration
4- Make a copy to your bot and fill it's details
5- Save and refresh

6- while in the bot, click the global google-speech config
7- click the bot google-speech config
The opened file will still refer to the global file.

Expected behavior
To view the file I clicked on

Screenshots
image

Environment (please complete the following information):
v12.26.0

botpress/borpress botpress/v12#1483 by @ bassamtantawi-botpress

@allardy
Copy link
Member

allardy commented Nov 17, 2021

I don't see how this brings any value
image

EFF added a commit that referenced this pull request Nov 18, 2021
@EFF
various fixes
43a8400 
fixed regex for matching text and _ (#153)
Added conditionType in saved payload (#156)
fix(debugger): Voice-Content Type in Emulator (#163) 
chore(debugger): fix missing translation (#172) 
fix: hardcoded query in context dropdown (#176) 
Fix: alt+enter not submitting on actions form (#181)
@laurentlp laurentlp deleted the pierre_fix_5465 branch November 22, 2021 15:48
@crochcunill
Copy link

Solved in version 12.26.7

This was referenced Dec 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EFF EFF EFF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ierezell @allardy @crochcunill @EFF