feat(studio): adds guided tour button to top #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also adds this step to the guided tour so people know to click to re-read : |
laurentlp
reviewed
Jan 10, 2022
| if (analytics) { | ||
| // analytics only defined if window.SEND_USAGE_STATS is true | ||
| return analytics.track(eventName, payload, options, callback) | ||
| analytics.track(eventName, payload, options, callback).catch(e => { | ||
| console.error('Analytics error - event', e) |
There was a problem hiding this comment.
Do we really want to log those errors? I don't think it has much value to let the user know that sending analytics failed. What do you think?
|
@ptrckbp Any update? |
samuelmasse
changed the title
samuelmasse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a little experiment to see if people want to use the tutorial / help buttons in app. On pages with no help icon (like the flow editor), a tutorial button appears (see images), where the help button would normally be and triggers the Guided Tour.
This also standardizes the buttons to have the same spacing, and icon + title.
On a page with no existing help button :
Before
After
On a page with an existing help button :
Before
After
This also adds analytics to the tutorial steps and simplifies the tracking implementation by removing error handling.