Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(studio): fix random error with lang switcher #253

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Conversation

allardy
Copy link
Member

@allardy allardy commented Jan 25, 2022

Fix a random error which happens sometimes with slower connections. Someone one call takes longer, and the lang switcher mounts, then unmounts, then remounts, but since it changed the value to null when unmounting, it crashed the studio.

Quick & dirty fix. Eventually we'll get rid of react-bootstrap once and for all

image

@allardy allardy merged commit 1fe38d5 into master Jan 26, 2022
@laurentlp laurentlp deleted the ya-fix-switcher branch February 3, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants