fix(nlu): intent slot formatting #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-2312 Intent Slot Formatting Bug
Styles for intent slots format incorrectly on smaller screen sizes |
rob-gordon
commented
Feb 15, 2022
Comment on lines
+80
to
+90
| // Fix duplicate placeholder | ||
| [data-slate-leaf='true'] > span > [contenteditable='false'] + span > [contenteditable='false'], | ||
| [data-slate-leaf='true'] | ||
| > span | ||
| > [contenteditable='false'] | ||
| + span | ||
| > [contenteditable='false'] | ||
| + span | ||
| > [contenteditable='false'] { | ||
| display: none !important; | ||
| } |
There was a problem hiding this comment.
I totally acknowledge how hacky this looks! It fixes a bug (which already existed) where the placeholder is rendered 3 times on the first line for some reason. I tried to fix it via the react-slate-placeholder plugin, but it's undocumented and unmaintained and I didn't have any luck :^\
franklevasseur
approved these changes
Feb 17, 2022
| @@ -6,7 +6,7 @@ $status-bar-height: 30px; | |||
| } | |||
|
|
|||
| .fullsize, | |||
| .fullsize > div { | |||
| .fullsize > :where(div) { | |||
There was a problem hiding this comment.
what is this sorcery ?? 🧙🏻♂️
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Screen.Recording.2022-02-15.at.3.45.28.PM.mov
After
Screen.Recording.2022-02-15.at.3.42.52.PM.mov