fix(security): fix access to public envs when bot is unmounted #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where unmounting a bot would prevent the user from accessing the bot settings page.
The issue came from the
checkBotVisibility
middleware that checks whether or not the bot is accessible (mounted). It contains an exception for the/env
route and placeholder bots (___
). Meaning that we were missing the exception for thepublic-env
route.