Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated testing of supported backends? #1117

Closed
hartwork opened this issue Jan 1, 2019 · 7 comments
Closed

Automated testing of supported backends? #1117

hartwork opened this issue Jan 1, 2019 · 7 comments

Comments

@hartwork
Copy link
Contributor

hartwork commented Jan 1, 2019

Hi!

Last time I checked support for multiple backends was broken. I did a superficial check for related tests in the repository now and didn't any, e.g. there is no test that backend waitress still works today. Am I missing something? Are there plans to get all backends covered by smoke tests at leasts? Are there tests that I am missing? Should I create a ticket for every backend I find broken?

Thanks and best, Sebastian

@defnull
Copy link
Member

defnull commented Jan 1, 2019

Backend integration tests proved to be very unstable on public CI systems (travis/circle) and reported a lot of false positives, so they were removed. If you find a way to test these in a more stable way, that would be great.

@hartwork
Copy link
Contributor Author

hartwork commented Jan 1, 2019

I'll see what I can do

@hartwork
Copy link
Contributor Author

hartwork commented Jan 1, 2019

Backend integration tests proved to be very unstable on public CI systems (travis/circle) and reported a lot of false positives

@defnull could you elaborate on that? What kind of false positives? What kind of instability?

@defnull
Copy link
Member

defnull commented Jan 1, 2019

Spawing a new process with a running server listening on localhost, waiting up to 10 seconds for the port to open, and then sending a single HTTP request, failed randomly. For various reasons. Either timeouts or port conflicts or other issues. I'm not exactly sure.

@hartwork
Copy link
Contributor Author

hartwork commented Jan 1, 2019

Let's find out 😃 Found the code in test/test_server.py by now.

@hartwork
Copy link
Contributor Author

hartwork commented Jan 1, 2019

@defnull #1118 is ready for a first round of review now. Commit messages carry extra details. I'm happy to make adjustments.
Please note we'll need some decision for #1119 to move on.

@hartwork
Copy link
Contributor Author

Closing as #1118 is merged by now. Please re-open as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants